Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change rom_id type to int in search endpoint #1420

Merged
merged 1 commit into from
Jan 5, 2025
Merged

fix: Change rom_id type to int in search endpoint #1420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/endpoints/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
@protected_route(router.get, "/search/roms", [Scope.ROMS_READ])
async def search_rom(
request: Request,
rom_id: str,
rom_id: int,
search_term: str | None = None,
search_by: str = "name",
) -> list[SearchRomSchema]:
"""Search for rom in metadata providers

Args:
request (Request): FastAPI request
rom_id (str): Rom ID
rom_id (int): Rom ID
source (str): Source of the rom
search_term (str, optional): Search term. Defaults to None.
search_by (str, optional): Search by name or ID. Defaults to "name".
Expand Down
Loading