fix: Make migrations compatible with PostgreSQL #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results91 tests 91 ✅ 26s ⏱️ Results for commit b9b7a8c. ♻️ This comment has been updated with latest results. |
This change only verifies that Alembic can upgrade and downgrade through all the current migrations. It does not verify that the application works correctly with PostgreSQL.
adamantike
force-pushed
the
fix/postgresql-migrations
branch
from
1a4fc23 to
b9b7a8c
Compare
adamantike
commented
Dec 30, 2024
| r1.platform_id = r2.platform_id | ||
| AND r1.id != r2.id | ||
| AND ( | ||
| (r1.igdb_id = r2.igdb_id AND r1.igdb_id IS NOT NULL AND r1.igdb_id != '') |
There was a problem hiding this comment.
r1.igdb_id != '' comparison is not needed, as the igdb_id column is Integer. This doesn't fail on MySQL/MariaDB, but PostgreSQL complain because of '' not being a possible value for the column.
gantoine
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only verifies that Alembic can upgrade and downgrade through all the current migrations. It does not verify that the application works correctly with PostgreSQL.
It also allows setting
ROMM_DB_DRIVERaspostgresql.