Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC Fixes Part I #1378

Merged
merged 8 commits into from
Dec 23, 2024
Merged

OIDC Fixes Part I #1378

merged 8 commits into from
Dec 23, 2024

Conversation

gantoine
Copy link
Member

  • Add OICD_PROVIDER env variable and display on login page with icon from CDN
  • Fetch JWKS url from /.well-known/openid-configuration endpoint of SSO provider

cc @dataway
Fixes #1377

@gantoine gantoine requested a review from adamantike December 23, 2024 14:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Test Results

92 tests  ±0   92 ✅ ±0   27s ⏱️ -2s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 71ae2fb. ± Comparison against base commit 6909a7d.

♻️ This comment has been updated with latest results.

dataway
dataway reviewed Dec 23, 2024
View reviewed changes
backend/config/__init__.py Outdated Show resolved Hide resolved
@gantoine gantoine merged commit f3ea0fb into master Dec 23, 2024
9 checks passed
@gantoine gantoine deleted the oidc-fixes-1 branch December 23, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataway dataway dataway left review comments

@zurdi15 zurdi15 zurdi15 approved these changes

@adamantike adamantike adamantike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gantoine @dataway @adamantike @zurdi15