fix: Update ROM deletion process to remove associated collections #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurdi15
changed the title
… streamline user data updates
zurdi15
force-pushed
the
fix/update-collection-on-rom-delete
branch
from
187da44 to
014427e
Compare
zurdi15
changed the title
Test Results88 tests 88 ✅ 26s ⏱️ Results for commit c6039cc. ♻️ This comment has been updated with latest results. |
gantoine
reviewed
Dec 5, 2024
| collection.roms = [rom_id for rom_id in collection.roms if rom_id != id] | ||
| db_collection_handler.update_collection( | ||
| collection.id, {"roms": collection.roms} | ||
| ) |
There was a problem hiding this comment.
should this instead happen in db_rom_handler.delete_rom as a side-effect?
There was a problem hiding this comment.
hmm idk, I stick to the idea of just interacting with one table per handler, but idk if that's the best approach
gantoine
approved these changes
Dec 5, 2024
|
The current solution looks good. An improvement we can add in the future, to avoid any race conditions and make the update atomic, is to have |
adamantike
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.