misc: Retrieve roms by filename from database in bulk during scan #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scanning process could try to fetch thousands of roms from the database, one by one, which is very inefficient, especially when only a few new roms are added to the library, as the overhead of database calls is very high compared to metadata API calls. This change introduces a new method in the roms handler to retrieve roms by their file names in bulk, which is used during the scan process to fetch a batch of roms at once, instead of one by one. It also avoids the `@with_details` decorator when fetching roms during the scanning process, as those details are not needed, and they were adding unnecessary joins and data decoding.
adamantike
force-pushed
the
misc/bulk-get-roms-by-filename-during-scan
branch
from
05e40c6 to
0a4c81d
Compare
gantoine
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scanning process could try to fetch thousands of roms from the database, one by one, which is very inefficient, especially when only a few new roms are added to the library, as the overhead of database calls is very high compared to metadata API calls.
This change introduces a new method in the roms handler to retrieve roms by their file names in bulk, which is used during the scan process to fetch a batch of roms at once, instead of one by one.
It also avoids the
@with_detailsdecorator when fetching roms during the scanning process, as those details are not needed, and they were adding unnecessary joins and data decoding.