[ROMM-540] OIDC Support #1321
Merged
[ROMM-540] OIDC Support #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results92 tests 92 ✅ 27s ⏱️ Results for commit 37db255. ♻️ This comment has been updated with latest results. |
gantoine
force-pushed
the
openid-connect
branch
from
fa09c59 to
f2f8956
Compare
gantoine
commented
Dec 13, 2024
| request.session.clear() | ||
|
|
||
| return {"msg": "Successfully logged out"} | ||
|
|
There was a problem hiding this comment.
this is unchanged, just moved it up
gantoine
commented
Dec 13, 2024
| @@ -102,7 +102,7 @@ async def lifespan(app: FastAPI) -> AsyncGenerator[None, None]: | |||
| app.include_router(states.router, prefix="/api") | |||
| app.include_router(tasks.router, prefix="/api") | |||
| app.include_router(feeds.router, prefix="/api") | |||
| app.include_router(config.router, prefix="/api") | |||
| app.include_router(configs.router, prefix="/api") | |||
There was a problem hiding this comment.
this is to stop vscode complaining when getting confused between the backend/config and config/__init__
gantoine
commented
Dec 13, 2024
| @@ -16,3 +16,4 @@ env = | |||
| SCHEDULED_UPDATE_SWITCH_TITLEDB_CRON=0 4 * * * | |||
| UPLOAD_TIMEOUT=20 | |||
| LOGLEVEL=DEBUG | |||
| OIDC_ENABLED=false | |||
There was a problem hiding this comment.
we set this for all tests so they run, but override it in OIDC handler tests
|
Just added the new |
adamantike
reviewed
Dec 18, 2024
gantoine
force-pushed
the
openid-connect
branch
from
086748b to
37db255
Compare
adamantike
approved these changes
Dec 18, 2024
|
Nice, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for authentication via an external OIDC server (Authentik, Authelia, etc). New
OIDC_env variables were added to connect to the OIDC provider. Hitting the endpoint/login/openidkicks off the OAuth flow, and the callback (with encrypted token) is handled by/oauth/openid.The dev docker-compose.yml now includes entries for running an authentik server locally (for dev and testing). Setup in authentik requires creating an OAuth Provider, then an Application using that provider.
Closes #540