Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider IGDB alternative names when checking for exact match #1301

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

adamantike
Copy link
Collaborator

IGDB provides alternative names for games, which we are currently not considering when checking for an exact match.

This change starts considering alternative names, in addition to the game's name and slug, when checking for an exact match.

IGDB provides alternative names for games, which we are currently not
considering when checking for an exact match.

This change starts considering alternative names, in addition to the
game's name and slug, when checking for an exact match.
Copy link

Test Results

88 tests  ±0   88 ✅ ±0   25s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 71ac92b. ± Comparison against base commit dcd240a.

@adamantike adamantike changed the title fix: Consider IGDB alternatives when checking for exact match fix: Consider IGDB alternative names when checking for exact match Nov 17, 2024
@adamantike adamantike merged commit 9c2036c into master Nov 17, 2024
8 checks passed
@adamantike adamantike deleted the fix/igdb-game-exact-match-alternative-names branch November 17, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants