fix: Personal tab mobile responsive #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurdi15
changed the title
adamantike
reviewed
Nov 1, 2024
| <v-col cols="11" md="9"> | ||
| <v-slider | ||
| :class="{ 'ml-4': mdAndUp }" | ||
| v-model="romUser.difficulty" |
There was a problem hiding this comment.
Both Difficulty and Completion sliders are triggering API request with each value change, so when the user clicks and drags in the Completion slider, from 0 to 100, we are sending 100 API requests to the backend.
This could be fixed in a separate PR, but we could find a way to trigger a single update.
There was a problem hiding this comment.
Hmm yeah you are right, we should be able to just detect the click release or the touch release. I'll invesyit for the next PR
adamantike
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed personal tab in the game details view on mobile