Update variables to MariaDB #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drcursor
commented
Oct 14, 2024
drcursor
commented
- Added comment directing people. to the example docker compose file.
- Changed variables to MARIADB as we are using the MARIADB container.
- Fixed small typo (missing "=")
…te-dev-instructions-for-arch-linux chore(README): Update dev instructions for Arch Linux users
Switched to MARIADB variables as we are using the MARIADB container
Added comment directing people. to the example docker compose file. Changed variables to MARIADB as we are using the MARIADB container
gantoine
approved these changes
Oct 14, 2024
|
We will need to revert this change. As can be seen here, the LinuxServer's MariaDB image only supports Considering that the official MariaDB image supports both |
adamantike
added a commit
that referenced
this pull request
Nov 6, 2024
This reverts changes introduced in #1243. The LinuxServer's MariaDB image only supports `MYSQL_` prefixed environment variables. Considering that the official MariaDB image supports both `MARIADB_` and `MYSQL_` prefixes, we can go back to `MYSQL_` temporarily, until LinuxServer image gets support for this new naming convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.