fix: Avoid query during import time to set add_user endpoint scopes #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `add_user` endpoint was querying the database at import time, to decide whether to enforce the `users.write` scope or not. This is problematic because the database might not be ready at import time. Also, the decided `scopes` was being maintained for the entire application lifetime, which is not ideal, as users can be created without having the `users.write` scope, until the application is restarted.
Test Results87 tests 87 ✅ 26s ⏱️ Results for commit 1df2707. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
add_userendpoint was querying the database at import time, to decide whether to enforce theusers.writescope or not. This is problematic because the database might not be ready at import time.Also, the decided
scopeswas being maintained for the entire application lifetime, which is not ideal, as users can be created without having theusers.writescope, until the application is restarted.