fix: Improve handling of Redis URL #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the creation of Redis URL, from a simple string interpolation, to using `yarl.URL`. The main benefit, besides not forgetting to set all five different variables on every Redis client initialization, is that user credentials are correctly URL-encoded, if present. Up until now, if a password had special characters, it could break the generated URL. This change also introduces support for a `REDIS_SSL` setting, which allows the user to specify if the Redis connection should use SSL or not.
Test Results81 tests 81 ✅ 24s ⏱️ Results for commit b81fbc5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the creation of Redis URL, from a simple string interpolation, to using
yarl.URL. The main benefit, besides not forgetting to set all five different variables on every Redis client initialization, is that user credentials are correctly URL-encoded, if present.Up until now, if a password had special characters, it could break the generated URL.
This change also introduces support for a
REDIS_SSLsetting, which allows the user to specify if the Redis connection should use SSL or not.