fix: Do not set Ruffle's renderer explicitly #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Ruffle documentation [1], the `preferredRenderer` option is only needed if a renderer needs to be enforced. When not provided: > By default, Ruffle chooses the most featureful backend supported by the > user's system, falling back to more basic backends if necessary. This commit removes the `preferredRenderer` option from the Ruffle configuration in the frontend, so that the default behavior is used. It also removes the noisy `logLevel` option, which was set to `debug`. Fixes rendering issue for `Boxhead: The Rooms`, reported in #1216. [1] https://github.com/ruffle-rs/ruffle/wiki/Using-Ruffle
gantoine
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Ruffle documentation [1], the
preferredRendereroption is only needed if a renderer needs to be enforced. When not provided:This commit removes the
preferredRendereroption from the Ruffle configuration in the frontend, so that the default behavior is used.It also removes the noisy
logLeveloption, which was set todebug.Fixes rendering issue for
Boxhead: The Rooms, reported in #1216.[1] https://github.com/ruffle-rs/ruffle/wiki/Using-Ruffle