fix: Use filename without tags or extension when matching unmatched game #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a game is manually unmatched, we update its `name` field to `file_name` (which includes both tags and extension). After that, if we go to the Rom list, and click on "Manual match" for that rom, the search field is populated with that Rom name, which commonly won't retrieve any results from the metadata providers. This change makes the "Manual match" search term to use the filename without tags or extension, when the Rom is currently not matched. It also triggers the search automatically when a search term was set. Potential fix for #1167.
gantoine
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a game is manually unmatched, we update its
namefield tofile_name(which includes both tags and extension). After that, if we go to the Rom list, and click on "Manual match" for that rom, the search field is populated with that Rom name, which commonly won't retrieve any results from the metadata providers.This change makes the "Manual match" search term to use the filename without tags or extension, when the Rom is currently not matched. It also triggers the search automatically when a search term was set.
Potential fix for #1167.