Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_diagnostics): fix the printing of empty diff lines #3382

Merged
merged 1 commit into from
Oct 11, 2022
Merged

fix(rome_diagnostics): fix the printing of empty diff lines #3382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/rome_cli/tests/snapshots/main_check/maximum_diagnostics.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ check.js:2:1 lint/correctness/useBlockStatements FIXABLE ━━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;)·{}for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -57,6 +58,7 @@ check.js:2:1 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + while·(true);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -77,6 +79,7 @@ check.js:2:13 lint/correctness/useBlockStatements FIXABLE ━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);for(;true;)·{}for(;true;);for(;true;);for(;true;);for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -97,6 +100,7 @@ check.js:2:13 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);while·(true);for(;true;);for(;true;);for(;true;);for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -117,6 +121,7 @@ check.js:2:25 lint/correctness/useBlockStatements FIXABLE ━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);for(;true;);for(;true;)·{}for(;true;);for(;true;);for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -137,6 +142,7 @@ check.js:2:25 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);for(;true;);while·(true);for(;true;);for(;true;);for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -157,6 +163,7 @@ check.js:2:37 lint/correctness/useBlockStatements FIXABLE ━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);for(;true;);for(;true;);for(;true;)·{}for(;true;);for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -177,6 +184,7 @@ check.js:2:37 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);for(;true;);for(;true;);while·(true);for(;true;);for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -197,6 +205,7 @@ check.js:2:49 lint/correctness/useBlockStatements FIXABLE ━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);for(;true;);for(;true;);for(;true;);for(;true;)·{}for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -217,6 +226,7 @@ check.js:2:49 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);for(;true;);for(;true;);for(;true;);while·(true);for(;true;);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -237,6 +247,7 @@ check.js:2:61 lint/correctness/useBlockStatements FIXABLE ━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;)·{}
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -257,6 +268,7 @@ check.js:2:61 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
2 │ + for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);while·(true);
3 3 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -278,6 +290,7 @@ check.js:3:1 lint/correctness/useBlockStatements FIXABLE ━━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 2 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ + for(;true;)·{}for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -300,6 +313,7 @@ check.js:3:1 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 2 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ + while·(true);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -322,6 +336,7 @@ check.js:3:13 lint/correctness/useBlockStatements FIXABLE ━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 2 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ + for(;true;);for(;true;)·{}for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -344,6 +359,7 @@ check.js:3:13 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 2 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ + for(;true;);while·(true);for(;true;);for(;true;);for(;true;);for(;true;);
Expand All @@ -366,6 +382,7 @@ check.js:3:25 lint/correctness/useBlockStatements FIXABLE ━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 2 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ + for(;true;);for(;true;);for(;true;)·{}for(;true;);for(;true;);for(;true;);
Expand All @@ -388,6 +405,7 @@ check.js:3:25 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 2 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ + for(;true;);for(;true;);while·(true);for(;true;);for(;true;);for(;true;);
Expand All @@ -410,6 +428,7 @@ check.js:3:37 lint/correctness/useBlockStatements FIXABLE ━━━━━━

i Suggested fix: Wrap the statement with a `JsBlockStatement`

1 1 │
2 2 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ + for(;true;);for(;true;);for(;true;);for(;true;)·{}for(;true;);for(;true;);
Expand All @@ -432,6 +451,7 @@ check.js:3:37 lint/correctness/useWhile FIXABLE ━━━━━━━━━━

i Suggested fix: Use a while loop

1 1 │
2 2 │ for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ - for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);for(;true;);
3 │ + for(;true;);for(;true;);for(;true;);while·(true);for(;true;);for(;true;);
Expand Down
9 changes: 7 additions & 2 deletions crates/rome_cli/tests/snapshots/main_ci/ci_does_not_run_linter.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,13 @@ file.js format ━━━━━━━━━━━━━━━━━━━━━

× File content differs from formatting output

2 │ → return·{·something·};
│ ++ +
1 │ -
2 1 │ function f() {
3 │ - return·{·something·}
2 │ + → return·{·something·};
4 3 │ }
5 4 │


```

Expand Down
Loading