Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): rule useValidAnchor #3369

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

ematipico
Copy link
Contributor

Summary

This PR closes #3303

I tried to add some extensive documentation for this rule.

Test Plan

Added various test cases

@ematipico ematipico requested a review from a team October 7, 2022 15:08
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for rometools ready!

Name Link
🔨 Latest commit 3dda60c
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/634043721a163200096240af
😎 Deploy Preview https://deploy-preview-3369--rometools.netlify.app/docs/lint/rules/usevalidanchor
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ematipico ematipico temporarily deployed to netlify-playground October 7, 2022 15:08 Inactive
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44939 44939 0
Failed 940 940 0
Panics 0 0 0
Coverage 97.95% 97.95% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1621 1621 0
Failed 4325 4325 0
Panics 0 0 0
Coverage 27.26% 27.26% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12395 12395 0
Failed 3862 3862 0
Panics 0 0 0
Coverage 76.24% 76.24% 0.00%

@ematipico ematipico force-pushed the feature/use-valid-anchor branch from d8f7c57 to 3dda60c Compare October 7, 2022 15:19
@ematipico ematipico temporarily deployed to netlify-playground October 7, 2022 15:19 Inactive
@ematipico ematipico merged commit e6dbf2a into main Oct 10, 2022
@ematipico ematipico deleted the feature/use-valid-anchor branch October 10, 2022 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useValidAnchor
2 participants