This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): improve the diagnostics emitted by noUnreachable
#3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
leops
force-pushed
the
fix/unreachable-range
branch
from
004b599 to
eb39b80
Compare
ematipico
approved these changes
Oct 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2961
This PR improves the range-merging logic of the
noUnreachablerule to allow large sections of unreachable code to be reconstructed from many disjoint instruction-level ranges. I also took the opportunity to rework how the advices emitted in the diagnostics are sorted and worded to make better use of the new diagnostics rendering.Test Plan
I've added a new
MergeRangestest case that checks the range merging works correctly for all the supported control flow statements, and I've updated a few other snapshots that were also impacted by this change.