This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(formatter): Change binary like expression to format left to right #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ea01272
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0189a681.tools-8rn.pages.dev |
MichaReiser
force-pushed
the
refactor/format-and-write-macros
branch
2 times, most recently
from
a464b8d to
8ac52ad
Compare
MichaReiser
force-pushed
the
refactor/binary-like-left-to-right
branch
from
bc3effd to
5bdaae9
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
💥 Failed to Panic (1):ts/babel
ts/microsoft
|
|
!bench_formatter |
Formatter Benchmark Results |
ematipico
reviewed
Jun 6, 2022
| /// The left or right sub part of a binary expression. | ||
| #[derive(Debug)] | ||
| enum FlattenedExpression { | ||
| /// The right hand sie of a binary expression. Needs to format the parent operator and the right expression |
There was a problem hiding this comment.
Suggested change
| /// The right hand sie of a binary expression. Needs to format the parent operator and the right expression | |
| /// The right hand side of a binary expression. Needs to format the parent operator and the right expression |
There was a problem hiding this comment.
Isn't "right expression" self in this case? If not, I am really missing the point of this struct
There was a problem hiding this comment.
The point of this struct is that it represents this
tools/crates/rome_js_formatter/src/utils/binary_like_expression.rs
Lines 50 to 53 in 6e8a3cb
Except that our current formatting actually formats this differently: It creates the following groups
some
&& thing
&& elsewhere
&& happy
Not sure if that's intentional but this isn't something I'm changing as part of this PR.
| // if none of the previous conditions is met, | ||
| // we take take out the first element from the rest of group, then we hard group the "head" | ||
| // and we indent the rest of the groups in a new line | ||
| write!(f, [groups.next().unwrap()])?; |
There was a problem hiding this comment.
Could we add a // SAFETY comment?
There was a problem hiding this comment.
Hmm maybe... That's copied 1:1, let me see if I can figure it out
There was a problem hiding this comment.
I missed this change unfortunately. But here we can safely tell that we always have at least two groups in a binary like expression.
Also, the comments seems to be outdated. We don't format the "head" in this branch.
ematipico
approved these changes
Jun 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the binary like expression formatting to lazily write the expressions rather than allocating vectors with the sub results.
The basic idea remains the same. The implementation flattens an expression. What's different to before is that this is now a two-stage process:
I think this also improves readability because it makes it clear what concepts exist in this algorithm (left hand side, right hand side, and a sub-group).
Test Plan
cargo test