This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d7cb2e
to
a213a81
Compare
a213a81
to
25fff34
Compare
leops
reviewed
Feb 1, 2022
MichaReiser
reviewed
Feb 1, 2022
b5808c7
to
866eae9
Compare
@MichaReiser @leops I update the description of the issue and applied your suggestions |
leops
reviewed
Feb 1, 2022
c09cdbe
to
a4b3824
Compare
leops
reviewed
Feb 1, 2022
b20fa66
to
ec1d052
Compare
leops
approved these changes
Feb 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of #1996
Closes #2030
I creates a new workflow to run the formatter against the libraries that we use to bench the parser.
I changed the key comments to trigger the benchmarks:
!bench_parser
will trigger the parser benchmarks!bench_formatter
will trigger the formatter benchmarkscargo benchmark
has been removedcargo bench_parser
cargo bench_formatter
Test Plan
Existing CI and run locally the new command.