Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

ci: formatter benchmarks #2029

Merged
merged 8 commits into from
Feb 1, 2022
Merged

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Jan 31, 2022

Summary

This PR is part of #1996
Closes #2030

I creates a new workflow to run the formatter against the libraries that we use to bench the parser.

I changed the key comments to trigger the benchmarks:

  • !bench_parser will trigger the parser benchmarks
  • !bench_formatter will trigger the formatter benchmarks
  • the old alias cargo benchmark has been removed
  • new cargo alias called cargo bench_parser
  • new cargo alias called cargo bench_formatter

Test Plan

Existing CI and run locally the new command.

@ematipico ematipico changed the title wip ci: formatter benchmarks Jan 31, 2022
@ematipico ematipico force-pushed the ci/formatter-benchmark branch 3 times, most recently from 5d7cb2e to a213a81 Compare January 31, 2022 17:46
@ematipico ematipico force-pushed the ci/formatter-benchmark branch from a213a81 to 25fff34 Compare January 31, 2022 17:53
@ematipico ematipico force-pushed the ci/formatter-benchmark branch from b5808c7 to 866eae9 Compare February 1, 2022 11:05
@ematipico
Copy link
Contributor Author

@MichaReiser @leops I update the description of the issue and applied your suggestions

@ematipico ematipico force-pushed the ci/formatter-benchmark branch from c09cdbe to a4b3824 Compare February 1, 2022 14:36
@ematipico ematipico force-pushed the ci/formatter-benchmark branch from b20fa66 to ec1d052 Compare February 1, 2022 14:52
@ematipico ematipico requested a review from leops February 1, 2022 14:53
@ematipico ematipico merged commit 343b28f into rome:main Feb 1, 2022
@ematipico ematipico deleted the ci/formatter-benchmark branch February 1, 2022 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a workflow where we format some big code bases and report its results into the CI.
3 participants