Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_formatter): template literals and static initializers #2021

Merged
merged 8 commits into from
Jan 31, 2022

Conversation

ematipico
Copy link
Contributor

Summary

This PR is part of #1996

  • renamed nodes that belong to templates by adding JS_ as prefix
  • emitted the new nodes
  • implemented formatting for template grammar
  • implemented formatting for static block initializers

Test Plan

Created new tests and updated existing ones

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 28, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9083de0
Status: ✅  Deploy successful!
Preview URL: https://34b29501.tools-8rn.pages.dev

View logs

@github-actions
Copy link

Test262 comparison coverage results on ubuntu-latest

Test result main count This PR count Difference
Total 45250 45250 0
Passed 44129 44129 0
Failed 1120 1120 0
Panics 1 1 0
Coverage 97.52% 97.52% 0.00%

| TsAssertion
| TsConstAssertion
| TsNonNull


Template =
JsTemplate =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@ematipico ematipico force-pushed the feature/format-templates branch from 776d27f to 79cb05f Compare January 28, 2022 13:56
@ematipico ematipico requested a review from leops January 28, 2022 17:08
@ematipico ematipico force-pushed the feature/format-templates branch from 6867580 to 7196c52 Compare January 31, 2022 08:47
@github-actions
Copy link

github-actions bot commented Jan 31, 2022

Parser conformance results on ubuntu-latest

TS

Test result main count This PR count Difference
Total 15976 15976 0
Passed 10471 10471 0
Failed 4153 4153 0
Panics 1352 1352 0
Coverage 65.54% 65.54% 0.00%

T262

Test result main count This PR count Difference
Total 45250 45250 0
Passed 44130 44130 0
Failed 1120 1120 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

@ematipico ematipico force-pushed the feature/format-templates branch from 7196c52 to 59a988b Compare January 31, 2022 09:08
@ematipico ematipico force-pushed the feature/format-templates branch from 59a988b to 9083de0 Compare January 31, 2022 10:20
@ematipico ematipico merged commit 7418d1f into main Jan 31, 2022
@ematipico ematipico deleted the feature/format-templates branch January 31, 2022 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants