Specify an opaque background for or FrostedContainer #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a problem if we don't want the blur management.
I added a
backgroundContainerColor
property to set an UIColor to the FrostedContainer.Typically, if we want
liveBlur
we have to specify it. ThebackgroundContainerColor
takes the priority to theliveBlur
if the color is different tonil
Moreover, if we don't want blur, it doesn't call
re_applyBlurWithRadius
function which costs a lot of CPU in... Main thread 👎 (before my request, the code test was if !liveBlur => call re_applyBlurWithRadius , it doesn't make sense ! Just let an opaque background.)Open to discuss to improve my quick feature to be sure that it doesn't break other blur management.
So, the other issue which have to be fixed is to manage efficiently the GraphicBlur processing to a background queue or whatever.