Add qualifed projections to schemas & update dataset#select calls
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
approved these changes
Mar 6, 2020
|
@solnic I'm OK with that. In general, I think we want to do something about caching |
|
@abrthel please squash commits and I'll merge this in |
abrthel
force-pushed
the
fix-attribute-aliases-370
branch
from
acafb76 to
0262df1
Compare
|
Not really sure what made those checks fail but commits have now been squashed! |
|
@solnic Hey, is there anything I should be doing to get this merged? As far as I can tell the tests failed before the test suite even ran. |
Yes, please rebase because the suite should pass now. |
Aliased attributes are context based and should default to the defined dataset name when using them in most queries. This fix provides a way to tell attributes they will be used in a context where their configured alias should override the default attribute name. As well this commit addresses: * Fix qualified function attributes Makes function attributes use the new qualified projection * Fix postgres commands /w aliased attributes Postgres commands were not returning tuples with the configured alias names.
abrthel
force-pushed
the
fix-attribute-aliases-370
branch
from
0262df1 to
d9f2058
Compare
|
Clones added
============
- lib/rom/sql/function.rb 2
See the complete overview on Codacy |
|
@solnic done! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
Aliased attributes are context based and should default to the
defined dataset name when using them in most queries.
This fix prevents attributes from being aliased during finalization
and provides a way to tell attributes they will be used in a
context where their configured alias should override the default
attribute name.
(Note: after review and before the pull request is accepted, ping me and I'll squash these commits)