-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): fix lint issues #1270
Conversation
bf36a53
to
c7c19b0
Compare
// source-map uses the presence of fetch to detect browser environments which | ||
// breaks in Node 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
export default class MyClass {} | ||
|
||
// eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's somewhat surprising that @typescript-eslint
doesnt detect this as used - maybe worth updating those deps and if it doesn't help then an issue could be raised there about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated ESLint but the issue persisted, maybe I would really need to change ESLint config directly, but as this is just a test, maybe we leave it as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits from my side - feel free to ignore all/some of them.
c7c19b0
to
ffebfa3
Compare
All done from my side. If there are no further concerns, I will merge tomorrow morning. |
e7e334d
to
fd54c7c
Compare
fd54c7c
to
82a73b5
Compare
Ok, maybe it is not that simple. I will look into the auto-install issues tomorrow. |
48ac907
to
6e64204
Compare
6e64204
to
c5fc648
Compare
Ok, I also needed to adjust the pnpm version in the CI scripts. One breaking pnpm change I came across is that arguments are now passed differently to scripts in some cases. That means
This is all working now nicely. I will merge this now as it is also blocking me very much, if there are still issues, I will be glad to make another PR. |
Rollup Plugin Name: all
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
linting issues in two packages were breaking the build for unrelated PRs. This is fixed here by adding proper comments. Also, the lock file is down-graded to match the version of pnpm installed as a dependency. It was accidentally upgraded by some of the recent PRs.
Additionally, I needed to add a fix for Node 18 in the Babel tests.