Proper scrubbing #510
Merged
Proper scrubbing #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianr
reviewed
Nov 20, 2017
| for (i = 0; i < keys.length; ++i) { | ||
| k = keys[i]; | ||
| v = obj[k]; | ||
| obj[k] = func(k, v, seen); | ||
| result[k] = func(k, v, seen); |
There was a problem hiding this comment.
This seems like clearly the right thing to do, but just to ask... are there any places that we currently use traverse where we actually do/might want to modify in-place?
There was a problem hiding this comment.
It is only used internally by the scrubbing method
bobzoller
added a commit
to goodeggs/rollbar-stream
that referenced
this pull request
Dec 12, 2017
fixes a pretty bad mutation bug: rollbar/rollbar.js#510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #508
Fixes #509
We should not modify an object in-place to scrub it.
We should not use an unanchored regular expression for testing whether to scrub a key.