fixes errMsg.match is not a function error #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this is a reasonable thing to check, I'd like to understand how we end up with an error with a message that does not have the String prototype. Unless someone throws an error that specifically sets message to null, because by default Error has the empty string as the message. But this is a good change, if we end up in that situation we shouldn't crash. |
|
Yeah I haven't been able to catch it. Some library I'm using is obviously not throwing a well formed error. |
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
fixes errMsg.match is not a function error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting errMsg.match is not a function error from https://cdnjs.cloudflare.com/ajax/libs/rollbar.js/2.3.1/rollbar.min.js