Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call callback even if logging same as last error #490

Merged
merged 2 commits into from
Nov 3, 2017
Merged

Call callback even if logging same as last error #490

merged 2 commits into from
Nov 3, 2017

Conversation

jcurlier
Copy link
Contributor

@jcurlier jcurlier commented Nov 2, 2017 •
edited
Loading

Fix #489

@jcurlier jcurlier changed the title Call callback even if same as last error Call callback even if logging same as last error Nov 2, 2017
@jcurlier jcurlier mentioned this pull request Nov 2, 2017
Closed
rokob
rokob approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@rokob rokob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokob rokob merged commit 84bf382 into rollbar:master Nov 3, 2017
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
@rokob
Merge pull request #490 from jcurlier/bugfix/callback_not_called
bda894c 
Call callback even if logging same as last error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokob rokob rokob approved these changes

Assignees

@rokob rokob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcurlier @rokob