Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the Telemeter::getLevelFromPsrLevel() method from private to public. #644

Merged

Conversation

danielmorell
Copy link
Collaborator

@danielmorell danielmorell commented Jan 10, 2025

Description of the change

Changed the Telemeter::getLevelFromPsrLevel() method from private to public. This is needed for the Laravel service provider, and could be useful for anyone using the PSR log standard who wants to send logs to telemetry.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added this to the v4.1.0 milestone Jan 10, 2025
@danielmorell danielmorell merged commit 81638a1 into master Jan 10, 2025
@danielmorell danielmorell deleted the changed/exposed-telemeter-getlevelfrompsrlevel-method branch January 10, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants