Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fallback message to Rollbar API rejection verbose log #611

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

cresjie
Copy link

@cresjie cresjie commented Mar 15, 2023

Description of the change

fix if message is not set

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

fix if message is not set
@danielmorell danielmorell self-requested a review March 16, 2023 11:16
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cresjie Thank you for this thoughtful contribution!

Unfortunately, the null coalescing operator is not available until PHP 7.4. v1.x of the SDK supports PHP 5. So, this change is incompatible with the SDK. You could replace it with an isset() inside a ternary.

@danielmorell danielmorell self-assigned this Mar 16, 2023
@danielmorell danielmorell added the Type: Bug Fix a component so that its behavior aligns with its documentation. label Mar 16, 2023
@danielmorell danielmorell changed the title Update RollbarLogger.php Added fallback message to Rollbar API rejection verbose log Mar 16, 2023
@cresjie
Copy link
Author

cresjie commented Mar 20, 2023

updated to isset()

@danielmorell danielmorell merged commit 0b48c80 into rollbar:next/1.x/main Mar 22, 2023
@cresjie
Copy link
Author

cresjie commented Mar 30, 2023

Hi @danielmorell,
Can you please do a release for v1.8.2. We're currently using rollbar/rollbar-laravel@4.* and requires rollbar/rollbar@^1

@danielmorell
Copy link
Collaborator

@cresjie v1.8.2 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants