avoid constructing Status where not necessary
#184
Merged
+24
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
commented
Feb 1, 2025
rofinn
reviewed
Feb 2, 2025
simeonschaub
added a commit
to simeonschaub/FilePathsBase.jl
that referenced
this pull request
Feb 4, 2025
Open
simeonschaub
force-pushed
the
sds/avoid_status
branch
from
36edc59 to
37aef8c
Compare
simeonschaub
added a commit
to simeonschaub/FilePathsBase.jl
that referenced
this pull request
Feb 4, 2025
simeonschaub
force-pushed
the
sds/avoid_status
branch
from
37aef8c to
c7829fb
Compare
also add some additional optimizations
simeonschaub
force-pushed
the
sds/avoid_status
branch
from
c7829fb to
080eba5
Compare
|
Seems fine to me. Looks like CI is has autodisabled again, but if there are issues after merging I'll fix them before tagging a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #182, ref #183 (comment)