Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131
Here, I define the "public" properties as the
getproperty
overloads, and the private properties as any remaining internal fields. My thinking is then downstream types can accept this or define their ownpropertynames
to declare which fields whey want to be private or not.I used
Base.merge_names
here; this is a Julia internal function so perhaps we should not depend on it. It has at least existed for 4 years (https://github.com/JuliaLang/julia/blame/ff001a4e1f5b7f949f5a2328520a7e78bc1957b4/base/namedtuple.jl#L211). The reason I wanted to use it is to have a fast way of merging the tuples of symbols without duplicates (a slow alternative would beTuple(unique((public_names..., fieldnames(T)...)))
).