Fixing path option #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also adds a basic smoke test around `librarian-puppet install` - ups the aruba "slow" timeout since install can take longer
ghost
assigned 
|
Thanks ! |
aussielunix
added a commit
that referenced
this pull request
Aug 6, 2012
--path is no longer hard coded to _modules/_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried out the new
--pathsupport discussed in #9, and it seems that one more step was required inLibrarian::Puppet::Environment#install_path.So I fixed that up, and I also got some basic testing around
librarian-puppet installwhile I was in there.Happy to modify any of this if you'd like anything changed.
🐠