remark out all currently failing unit tests. Fixes #2137 #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All currently failing unit tests on our to-be-legacy but still reference CentOS source build are remarked out in order that we can more readily use the existing tests as indicators of disparity between our ditro bases. In almost all cases the fail/error message of the test is noted in TODO's. The vast majority failures are suspected as being caused by a lack of maintenance within the tests and several major changes such as disk/share/pool/network API changes Includes: - Remark out 2 sftp sub tests, broken/out of sync with core code. - Remark out test_btrfs_disk_import: 500 not 200. - Fix broken test_commands.py CommandTests - core refactor bit rot. see: "[openSUSE] use zypper for package installs. Fixes rockstor#2071" (pr rockstor#2081) in 3.9.2-51. The unrelated get_pool_info() breakage was not tracked down. - Update patch targets due to core refactoring. In pr: "Add unit testing for core network functions" rockstor#2045 at least a couple of functions were renamed. Updated these in our network API test setup. - Remark out all network API tests as this API changed long ago. - Remark out many whole and sub-parts of the nfs tests. Many of the failures here are likely down to disk / share API changes after these tests were written. Specifically Shares API in this case as there are many (noted in TODO: comments): "share instance ... does not exist." which suggests a failure of the mocking arrangement. - Remark out test_share_acl as currently non working and need work. - An attempt was made to fix the mocking required to have this test work but it was not a success. Minor minification were left in place never-the-less. - Remark out test within test_oauth_apply - Needs updating. - Update to account for refactoring in tested & add new needed mocks. - Since this test was update there have been a few pool model changes. The added mocks mostly move this test back to where it was prior to the pool management code changes. - Remove overly ambitious/broad test_raid_migration - failing. - Fix missing space in expected error message test_raid6_crud. - Remark out currently unworkable sub tests within test_raid6_crud. - Our pool / disk member mocking is currently insufficient and so a range of tests now fail. Remove for to use what we can. - Remark out currently unworkable sub tests within test_raid1_crud. - Our pool / disk member mocking is currently insufficient and so a range of tests now fail. Remove for to use what we can. - Remark out several sub tests within test_samba.py as need fixing. - Remark out a sub test within test_group as need fixing or OOD. - Remark out a sub test within test_login as non representative. - Remark out a sub test within test_shares as incorrectly triggered. - Remark out all but on test in test_oauth as test seem broken. - Remark out one more test in test_snapshots as known to be duff. - Remark out several more test in test_user as known to be duff.
|
@FroggyFlox As this pr makes no changes to end user running code I'm going to merge directly so we can start using the result for our current endeavours. We can always teak as we go fairly easily in this area anyway. |
phillxnet
deleted the
2137_temporarily_remark_out_all_currently_failing_unit_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All currently failing unit tests on our to-be-legacy but still reference CentOS source build are remarked out in order that we can more readily use the existing tests as indicators of disparity between our ditro bases. In almost all cases the fail/error message of the test is noted in TODO's. The vast majority failures are suspected as being caused by a lack of maintenance within the tests and several major changes such as disk/share/pool/network API changes.
Fixes #2137
See issue text for context.
Includes:
Tested on a source build via our CentOS variant via:
with the following summary:
and the following test output: