Scheduled shutdown task fails due to type issue

[Hooverdan96]

Thanks to user aymenSo, it appears that a scheduled shutdown task fails ultimately due to a type error, which results in a low-level exception during the attempt to execute the shutdown program.

this can likely be traced back to this part of the code:

rockstor-core/src/rockstor/storageadmin/views/command.py

Lines 304 to 310 in 6c86e38

	if request.auth is not None:
	delay = 3
	if command == "shutdown":
	msg = "The system will now be shutdown."
	try:
	# if shutdown request coming from a scheduled task

[phillxnet EDIT] As documented in the forum thread, the delay variable should be populated with +3 instead of just 3 following the shutdown man page:

https://man7.org/linux/man-pages/man8/shutdown.8.html

Should be an easy fix, however, not sure how one would design a test to this (or whether that is necessary) without shutting down the system every time :) (maybe trigger the shutdown and then cancel it within the delay time?).

---

Forum reference: https://forum.rockstor.com/t/error-on-shutdown-task/9313

[Hooverdan96]

Based on the referenced issue #2807 this use case could be addressed possibly with changing the delay assignment to

    if request.auth is not None:
        delay = str(3)

...

[phillxnet]

I'm working on the referenced/linked issue in #2805 (comment), so will add this change according there. And if all is well we can close this issue as a duplicate.

[phillxnet]

I've now split this out into it's own pull request: there were a few comment updates etc and shutdown/reboot specific changes that make it cleaner that way. PR currently under test.

[phillxnet]

Closing as:
Fixed by #2812