Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand README.md to include recent jslibs license clarifications. #2489

Closed
phillxnet opened this issue Jan 28, 2023 · 1 comment
Closed

Expand README.md to include recent jslibs license clarifications. #2489

phillxnet opened this issue Jan 28, 2023 · 1 comment
Assignees
@phillxnet
Milestone
First Stable Poet...

Comments

@phillxnet
Copy link
Member

phillxnet commented Jan 28, 2023 •
edited
Loading

We currently have reference to our AGPLv3 Rock-ons within our README.md which is included in our distributed package, but we are missing a similar reference to our jslibs license recently clarified in it's own README.md here:
https://github.com/rockstor/rockstor-jslibs#readme i.e.:
SPDX-License-Identifier: (MIT AND Apache-2.0 AND GPL-3.0-or-later AND LGPL-3.0-or-later AND ISC)

It is further proposed that we similarly move to the SPDX format while making these changes.

We can then reference this rockstor-core README.md as an overall licensing readme within our packaging, which does not include Rock-ons by default but does include the contents of the rockstor-jslibs. A further detail that would be nice to include up-front in this README.md.
@phillxnet phillxnet mentioned this issue Jan 28, 2023
Closed
@phillxnet phillxnet added this to the First Stable Poetry build milestone Feb 16, 2023
@phillxnet phillxnet self-assigned this Feb 16, 2023
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Feb 16, 2023
@phillxnet
Improve README.md re package licensing, project goals etc rockstor#2489
aeae1e7 
Improve licensing details re clarifications from the
distributed package point-of-view. This file can then
be referenced, within the packaging system itself,
as an overview, given it central location in our
rockstor-core repository. Includees some section
re-ordering to collect license and repo information.
SPDX references were adopted through-out.
@phillxnet phillxnet mentioned this issue Feb 16, 2023
Merged
phillxnet added a commit that referenced this issue Feb 17, 2023
@phillxnet
Merge pull request #2497 from phillxnet/2489_Expand_README.md_to_incl…
96d9228 
…ude_recent_jslibs_license_clarifications

Improve README.md re package licensing, project goals etc #2489
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
First Stable Poetry build
Development

No branches or pull requests
1 participant
@phillxnet