Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(t) 4.5.4-0 Samba shares fail #2471

Closed
phillxnet opened this issue Jan 18, 2023 · 3 comments
Closed

(t) 4.5.4-0 Samba shares fail #2471

phillxnet opened this issue Jan 18, 2023 · 3 comments
Assignees
@phillxnet
Milestone
First Stable Poet...

Comments

@phillxnet
Copy link
Member

phillxnet commented Jan 18, 2023 •
edited
Loading

Thanks to forum member Mark93 for highlighting this issue and @FroggyFlox for the initial diagnosis. We have a path failure in our samba "root preexec = " entries where we inadvertently reference our now legacy build systems' script entry points:
(See: Replace Buildout with Poetry #2432 #2434)

before 4.5.4-0:

/opt/rockstor/bin

4.5.4-0 +:

/opt/rockstor/.venv/bin

The following is an in-place work around post encountering this issue, provided by @FroggyFlox .

sed -i 's:/opt/rockstor/bin:/opt/rockstor/.venv/bin:g' /etc/samba/smb.conf
systemctl restart smb nmb

Canonical forum reference:
https://forum.rockstor.com/t/smb-shares-inaccesible-after-v4-5-4-0-upgrade/8627
@phillxnet phillxnet self-assigned this Jan 18, 2023
@phillxnet
Copy link
Member Author 

grep -R "preexec"
src/rockstor/system/samba.py:        fo.write('    root preexec = "{} {}"\n'.format(mnt_helper, e.share.name))
src/rockstor/system/samba.py:        fo.write("    root preexec close = yes\n")

@phillxnet
Copy link
Member Author

rockstor-core/src/rockstor/system/samba.py

Line 52 in 0249f52

mnt_helper = os.path.join(settings.ROOT_DIR, "bin/mnt-share")

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 18, 2023
@phillxnet
(t) 4.5.4-0 Samba shares fail rockstor#2471
567fc6e 
Correct samba mnt-share script path to account for new
.venv dir location on account of changed build system.
# Includes
- Package version increase as first change after
4.5.4-0 tagged release.
@phillxnet phillxnet mentioned this issue Jan 18, 2023
Merged
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 18, 2023
@phillxnet
(t) use matched jslibs_version rockstor#2471
ee513d0 
Mostly a cosmetic but less confusing if we
keep these in sync with our package version.
Should help with testing our upgrade system
on this front also.
@phillxnet phillxnet added this to the First Stable Poetry build milestone Jan 18, 2023
phillxnet added a commit that referenced this issue Jan 18, 2023
@phillxnet
Merge pull request #2472 from phillxnet/2471_(t)_4.5.4-0_Samba_shares…
ccd21f7 
…_fail

(t) 4.5.4-0 Samba shares fail #2471
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
First Stable Poetry build
Development

No branches or pull requests
1 participant
@phillxnet