Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant cubism.v1.js- rockstor-jslibs related #2455

Closed
phillxnet opened this issue Dec 20, 2022 · 1 comment
Closed

remove redundant cubism.v1.js- rockstor-jslibs related #2455

phillxnet opened this issue Dec 20, 2022 · 1 comment
Assignees
@phillxnet

Comments

@phillxnet
Copy link
Member

This library is no longer used so we should remove it's reference.

grep -R "cubism"
src/rockstor/storageadmin/templates/storageadmin/base.html:    <script src="/static/js/lib/cubism.v1.js"></script>
src/rockstor/storageadmin/templates/storageadmin/setup.html:    <script src="/static/js/lib/cubism.v1.js"></script>

See the rockstor-jslibs issue for context: rockstor/rockstor-jslibs#28
@phillxnet phillxnet self-assigned this Dec 20, 2022
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Dec 20, 2022
@phillxnet
remove redundant cubism.v1.js - rockstor-jslibs related rockstor#2455
9ed90fb 
Remove reference to unused js script form setup.html & base.html.
@phillxnet phillxnet mentioned this issue Dec 20, 2022
Merged
phillxnet added a commit that referenced this issue Dec 20, 2022
@phillxnet
Merge pull request #2456 from phillxnet/2455_remove_redundant_cubism.…
f27b1e0 
…v1.js-_rockstor-jslibs_related

remove redundant cubism.v1.js - rockstor-jslibs related #2455
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet