Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve disk removal error message formatting re pool free space #2388

Closed
phillxnet opened this issue Jun 29, 2022 · 1 comment
Closed

Improve disk removal error message formatting re pool free space #2388

phillxnet opened this issue Jun 29, 2022 · 1 comment
Assignees
@phillxnet

Comments

@phillxnet
Copy link
Member

When removing one or more disks and exceeding pool free space we have a poorly formatted user targeted error message:

"Removing disks ([u'virtio-1']) may shrink the pool by ... KB, which is greater than available free space ... KB. This is not supported."

Due to a literal dumping of the Python list type containing one or more disk names to be removed.

It is proposed that we instead present the more user friendly:

"Removing disk/s (virtio-1) may shrink the pool by ... KB, which is greater than available free space ... KB. This is not supported."

with it's mult-disk counterpart of:

"Removing disk/s (virtio-1 virtio-2) may shrink the pool by ... KB, which is greater than available free space ... KB. This is not supported."

The proposed code change to be submitted against this issue already has test counterparts in the ongoing work against issue #2384.
@phillxnet phillxnet self-assigned this Jun 29, 2022
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 29, 2022
@phillxnet
Improve disk removal error message formatting re pool free space rock…
742229a 
…stor#2388

Avoid literal dumping of the Python list type containing one or more
disk names to-be-removed into user facing error message.
@phillxnet phillxnet mentioned this issue Jun 29, 2022
Merged
phillxnet added a commit that referenced this issue Jun 29, 2022
@phillxnet
Merge pull request #2389 from phillxnet/2388_Improve_disk_removal_err…
387fd27 
…or_message_formatting_re_pool_free_space

Improve disk removal error message formatting re pool free space #2388
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet