Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yet another JMS567 controller serial obfuscation detection #2330

Closed
phillxnet opened this issue Dec 12, 2021 · 1 comment · Fixed by #2345
Closed

Add yet another JMS567 controller serial obfuscation detection #2330

phillxnet opened this issue Dec 12, 2021 · 1 comment · Fixed by #2345
Assignees
@phillxnet
Milestone
First 4 Stable (ISO)

Comments

@phillxnet
Copy link
Member

phillxnet commented Dec 12, 2021 •
edited
Loading

Thanks to Miyuki in the following forum thread for reporting another instance of a JMS567 based external drive enclosure miss-representing multiple drive serials as one.

NAME=“sdb” MODEL=“Generic_DISK00” SERIAL=“0123456789ABCDEF” SIZE=“1.8T” TRAN="" VENDOR=“JMicron " HCTL=“0:0:0:1” TYPE=“disk” FSTYPE=”" LABEL="" UUID=""
NAME=“sdd” MODEL=“Generic_DISK01” SERIAL=“0123456789ABCDEF” SIZE=“1.8T” TRAN="" VENDOR=“JMicron " HCTL=“0:0:0:3” TYPE=“disk” FSTYPE=”" LABEL="" UUID=""
NAME=“sde” MODEL=“Generic_DISK02” SERIAL=“0123456789ABCDEF” SIZE=“3.6T” TRAN="" VENDOR=“JMicron " HCTL=“0:0:0:4” TYPE=“disk” FSTYPE=”" LABEL="" UUID=""
NAME=“sdf” MODEL=“Generic_DISK03” SERIAL=“0123456789ABCDEF” SIZE=“1.8T” TRAN="" VENDOR=“JMicron " HCTL=“0:0:0:5” TYPE=“disk” FSTYPE=”" LABEL="" UUID=""

Forum reference::
https://forum.rockstor.com/t/can-i-avoid-this-error-houston-weve-had-a-problem-duplicate-key-value-violates-unique-constraint-storageadmin-disk-name-key/8137

Please also see the last pull request concerning a near identical change associated with a different serial number:
"Add another JMS567 controller serial obfuscation detection #2318" #2320
#2320
@phillxnet phillxnet added this to the First 4 Stable (ISO) milestone Dec 12, 2021
@phillxnet phillxnet self-assigned this Dec 29, 2021
@phillxnet
Copy link
Member Author

I am currently working on this issue.

@phillxnet phillxnet changed the title Add yet additional JMS567 controller serial obfuscation detection Add yet another JMS567 controller serial obfuscation detection Jan 7, 2022
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 10, 2022
@phillxnet
Centralise device serial rejection system rockstor#2330
48e147b 
Previously we had both backend (Python) and frontend(js) serial
rejections mechanisms. The former dealt with empty or repeat device
serial rejection/mitigation. The latter was used to inform the user
similarly of the former and it's own 'store' of known unreliable or
repeating within an external enclosure device serials.

Move all fake serial determination to the backend under the existing
'fake-serial-*' tag mechanism. Leaving the front end to react only to
this serial 'flag'.

## Includes:
- The addition of yet another unusable serial number associated with
a JMS567 multi-dev external enclosure.
- The removal from frontend js of a now defunct flag mechanism that
looked for drive name as serial number.
@phillxnet phillxnet mentioned this issue Jan 10, 2022
Merged
phillxnet added a commit that referenced this issue Jan 10, 2022
@phillxnet
Merge pull request #2345 from phillxnet/2330_centralise_device_serial…
f10beb9 
…_rejection_system

Centralise device serial rejection system #2330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
First 4 Stable (ISO)
Development

Successfully merging a pull request may close this issue.

Centralise device serial rejection system #2330 phillxnet/rockstor-core
1 participant
@phillxnet