-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin version, or drop 'coverage' re Python 2-3 move #2325
Comments
Thanks, @phillxnet ! Personally, I would vote for option 1 as dropping it might have repercussions that we might not see right away... It seems safer to me and we can always revisit our "pinnings" once #1877 is behind us (it is my understanding that such revisiting will be required for #1877 anyway). |
@FroggyFlox Thank. And initially I was favouring this option also. But my current incomplete understanding of our prior coverage use was for the raw data of for example the now defunct sub domain of coverage. I.e. see the following forum post: And given we have quite a few changes in-the-works I was hoping that was it's only reason to have been included. Looking into this now and will report back here when I have a little more background. It it is indeed unused currently then I think we would be best to go for option 2. |
@FroggyFlox It's addition dates back to May 4, 2015 via the following commit: f95b797#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7 |
I can also find no other mention of it's use via:
I'm currently working on the assumption this is an optional test coverage metrics generation tool and given we are not currently using it to generate any results (i.e. in the way we run our tests for example) we can safely remove it until we are ready to re-add it post our python 2 to 3 migration. Cutting down on the moving parts. At that point we can re-assess if coverage works for us. And it does look like a nice tool. But less moving parts, especially ones we aren't using, has to be the way to go during a major transition point. And given we have a build breakage here this is a fairly significant issue. I'll create a pr and use it to test build scenarios. |
…2325 Although version 5.5 still has Python 2.7 compatibility we are not currently making use of coverage's facilities as we once did a few years ago. So remove for the time being and consider re-adding post our own Python 2 to 3 migration.
…verage'_re_Python_2-3_move Remove coverage library as unused and now requires Python 3 #2325
Thanks to @FroggyFlox for highlighting this issue. We currently depend upon coverage and do not specify a version. However the more recent versions of coverage have dropped Python 2.7 compatibility.
See our own issue regarding doing the same here: "move to python 3" #1877
References:
Coverage changelog: https://coverage.readthedocs.io/en/latest/changes.html#version-6-0b1-2021-07-18
It is proposed that we, for the time being, either:
The text was updated successfully, but these errors were encountered: