Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm_build_info: 'rockstor' hardcoded in error #2306

Closed
chrstphrchvz opened this issue Jul 26, 2021 · 1 comment · Fixed by #2307
Closed

rpm_build_info: 'rockstor' hardcoded in error #2306

chrstphrchvz opened this issue Jul 26, 2021 · 1 comment · Fixed by #2307

Comments

@chrstphrchvz
Copy link
Contributor

chrstphrchvz commented Jul 26, 2021

In the rpm_build_info function, the rockstor package is hardcoded in one of the possible errors:

logger.info('No "rockstor" package found: source install?')

Since the function is getting the package name from the pkg argument, pkg should be used in the error instead, even though the function is currently only used to check for the rockstor package.

@phillxnet
Copy link
Member

@chrstphrchvz Agreed. Nice.
Thanks for your continued efforts in this part of the code. Much appreciated. Hopefully I can take a closer look at this soon. Unless @FroggyFlox beats me to it of course.

phillxnet added a commit that referenced this issue Aug 17, 2021
Pass string with pkg to logger.info() #2306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants