Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy kernel version maintenance #2246

Closed
phillxnet opened this issue Jan 7, 2021 · 1 comment · Fixed by #2251
Closed

remove legacy kernel version maintenance #2246

phillxnet opened this issue Jan 7, 2021 · 1 comment · Fixed by #2251

Comments

@phillxnet
Copy link
Member

Further to our transitional grubby dependency removal and the end of CentOS based rpm releases (3.9.2-57) we can now remove the remaining grubby calls/references system wide, most notably in our initrock mechanism: our overarching system initialisation routine. See set_def_kernel(). The associated 'supported kernel' checks are likewise now redundant as we no longer have a need to manage/maintain our kernel versions nor the low level tool (grubby) to enforce a kernel version change. This mechanism is a legacy artefact of our earlier days where we were required to update our base OS's kernel in order to achieve basic btrfs competency. This is no longer the case.

Summary of proposal:

  • We report only the kernel version and remove all mechanisms of version evaluation or enforcement. N.B. all mechanisms proposed for removal are currently non functional/deactivated within our 'Built on openSUSE' base.

Previous issue/pr references for the grubby dependency removal:
"remove grubby dependency for kernel version reporting" #1955
"remove grubby dependency for kernel version reporting. Fixes #1955" #1956

Indicated log error for this issue:

Installing def-kernel.
def-kernel: Running 'grubby --set-default=/boot/vmlinuz-'4.12.4-1.el7.elrepo.x86_64''
/bin/sh: grubby: command not found

Code references:

src/rockstor/scripts/initrock.py

set_def_kernel()
delete_old_kernels()

buildout.cfg & testing.cfg

[def-kernel]

src/rockstor/system/osi.py

kernel_info()

src/rockstor/smart_manager/data_collector.py

send_kernel_info()

@phillxnet
Copy link
Member Author

I am currently working on this issue.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 7, 2021
Summary of changes:
- Initrock: remove legacy kernel version enforcement, remove
delete_old_kernels(), remove grubby command reference.
- Buildout/testing.cfg: remove def-kernel mechanism.
- Settings/test-settings.conf.in: remove SUPPORTED_KERNEL_VERSION.
- Buildout/prod-buildout/testing.cfg: remove kernel settings var.
- Remove version evaluation from kernel_info(). The legacy functionality
of kernel_info(), if grubby executable path found, was to call grubby to
enforce a kernel version and emmit an exception which was used by the
front end, via data_collector, to surface kernel version errors. Remove
this functionality so that kernel_info() reports only kernel version
number for Web-UI use. The associated frontend KernelError
listener/processor was was removed.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 9, 2021
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 9, 2021
phillxnet added a commit that referenced this issue Jan 10, 2021
…sion_maintenance

remove legacy kernel version maintenance (#2246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant