Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate field label for Certificate path in LDAP service configuration form #2244

Closed
FroggyFlox opened this issue Jan 5, 2021 · 2 comments · Fixed by #2247
Closed

Inaccurate field label for Certificate path in LDAP service configuration form #2244

FroggyFlox opened this issue Jan 5, 2021 · 2 comments · Fixed by #2247

Comments

@FroggyFlox
Copy link
Member

Following our rework of LDAP implementation (#2235), we now require the user to provide a path to TLS certificate rather than a URL to the certificate. Unfortunately, the corresponding form label was not updated accordingly in #2235 (my fault). See example below:
image

This can be rather misleading to the user and should thus be changed to Certificate path rather than "Certificate URL".

@FroggyFlox
Copy link
Member Author

@phillxnet, my apologies for missing something so obvious in my related PR. I'll submit another PR to fix this inaccuracy soon.

@phillxnet
Copy link
Member

@FroggyFlox Nice find and apologies from me also for not catching this in the review. Oh well, at least we have it now and it should be a nice little fix to pop in ready for the next Stable channel release.

FroggyFlox added a commit to FroggyFlox/rockstor-core that referenced this issue Jan 7, 2021
phillxnet added a commit that referenced this issue Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants