Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor retry functinoality into a separate package #147

Merged
merged 1 commit into from
Oct 3, 2023
Merged

refactor retry functinoality into a separate package #147

merged 1 commit into from
Oct 3, 2023

Conversation

pmenglund
Copy link
Member

@pmenglund pmenglund commented Oct 3, 2023 •
edited
Loading

move retry functionality into its own package, and move test functions into the internal test package

@coveralls
Copy link
Collaborator

coveralls commented Oct 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 782

  • 14 of 18 (77.78%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 56.835%
Changes Missing Coverage Covered Lines Changed/Added Lines %
wait.go 4 5 80.0%
retry/exponential.go 2 5 40.0%
Totals Coverage Status
Change from base Build 780: -0.2%
Covered Lines: 1871
Relevant Lines: 3292
💛 - Coveralls

@pmenglund pmenglund requested a review from a team October 3, 2023 17:32
adamsb6
adamsb6 approved these changes Oct 3, 2023
View reviewed changes
Copy link

@adamsb6 adamsb6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think there might be some unwanted commented out code though.

vcr_test.go Outdated Show resolved Hide resolved
@pmenglund pmenglund enabled auto-merge (squash) October 3, 2023 20:21
@pmenglund pmenglund merged commit ef60670 into master Oct 3, 2023
@pmenglund pmenglund deleted the pme/retry branch October 3, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsb6 adamsb6 adamsb6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmenglund @coveralls @adamsb6