-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New iOS 9.1 emojis, emoji modifiers (skintones, etc) #96
Conversation
…ag emojis, add single unicode emojis to sEmojisMap for easy retrieval, refactor code to correctly handle keycap emojis when a non-spacing combining mark is used, handle modifier emojis (skin tones, flags, etc.) by getting drawable resourceId from unicode name rather than adding them all individually to another map
I think the reason for using the hash map is because Google discourages use of
|
Hm yea makes sense. Seems like using actual reflection is way faster (5x) than using http://daniel-codes.blogspot.com/2009/12/dynamically-retrieving-resources-in.html Still not as fast as the map but probably a negligible difference. And significantly easier to maintain. @rockerhieu if you want to make a decision on this I'll update the PR if necessary |
I like your solution, it's clean, and easier to maintain. But given the library already had a poor performance when rendering a lot of emoji at a time, I think we should not make it slower. How about this:
The first time an emoji is rendered, it will take a little more time, but it should be fast from the second time. What do you guys think? |
…ier for the same resource
So after digging into this it seems like the pure reflection method is faster because you only have to do 1 reflection lookup whereas |
@rockerhieu gentle nudge...how are we feeling about this? |
New iOS 9.1 emojis, emoji modifiers (skintones, etc)
Looks good 👍 |
Thanks! But I think it's missing the new emojis in the UI (I mean they are parsed but they can't be typed in). |
Addresses issues #82 and #85.
I did this:
for handling emoji modifiers rather than adding (64x5) more elements to a map. I'm not totally sure if this will work everywhere but if it does it seems like we could do something like this for all the emojis rather than managing those huge maps since all of the drawables are appropriately named.