Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS Travis build #153

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Fix macOS Travis build #153

merged 2 commits into from
Dec 21, 2018

Conversation

lrapetti
Copy link
Member

@lrapetti lrapetti commented Dec 20, 2018

As discussed in lrapetti#4.
Fix #141, and closes #149

As discussed in #4.
Fix robotology#141, and close robotology#149
@traversaro
Copy link
Member

A lot of test failed, but that is probably due to something else.

@traversaro
Copy link
Member

There is a new macOS error, see https://travis-ci.org/robotology/robotology-superbuild/jobs/470411651 .

@traversaro
Copy link
Member

Hopefully 0df2f77 should fix it finally.

@lrapetti
Copy link
Member Author

There is a new macOS error, see https://travis-ci.org/robotology/robotology-superbuild/jobs/470411651 .

My bad, I forgot to remove that workaround in this PR,
it seems it was no longer necessary (https://changelog.travis-ci.com/oclint-is-removed-from-mac-builds-79270).
Now everything should be fixed.

@traversaro traversaro merged commit 9e621be into robotology:master Dec 21, 2018
@diegoferigo
Copy link
Member

@lrapetti @traversaro For the record, I just discovered that if the before_install step is missing, the addon for homebrew does not work. Probably in your case it didn't work due to this reason, I opened a bug upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis CI on macOS is broken
3 participants