Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the solver is initialized in some methods of Solver class #89

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Check if the solver is initialized in some methods of Solver class #89

merged 1 commit into from
Mar 26, 2021

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Mar 26, 2021 •
edited
Loading

This fixes #88

Related to #87
cc @chenguoxi1987

@GiulioRomualdi GiulioRomualdi self-assigned this Mar 26, 2021
S-Dafarra
S-Dafarra approved these changes Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I just noticed that also some documentation of these methods is missing, but I can open an issue for that and open a PR later.

@GiulioRomualdi GiulioRomualdi merged commit 0f3f8c7 into master Mar 26, 2021
@GiulioRomualdi GiulioRomualdi deleted the fix/solver_not_initialized branch March 26, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Dafarra S-Dafarra S-Dafarra approved these changes

@traversaro traversaro traversaro approved these changes

Assignees

@GiulioRomualdi GiulioRomualdi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several of the Solver methods may result in a segfault if the solver is not initialized
3 participants
@GiulioRomualdi @traversaro @S-Dafarra