-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo, add getGradient, add package.xml to build in catkin workspaces #109
Conversation
wxmerkt
commented
Dec 11, 2021
- Fixes typos including in method names
- Add getGradient to return the last gradient
- Adds a package.xml to build in catkin/colcon workspaces
…o robotology-master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, thanks in any case!
Co-authored-by: Silvio Traversaro <[email protected]>
package.xml
Outdated
<?xml version="1.0"?> | ||
<package format="3"> | ||
<name>osqp-eigen</name> | ||
<version>0.6.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, not blocking the merge but I am tipically afraid of multiple places in which the version is defined. @GiulioRomualdi note that this may need to be updated for every new release, if necessary we can setup tooling to do this automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise we can modify the CMake to read the version from package.xml, for example dart is doing it via:
# Extract version numbers from package.xml
file(READ package.xml PACKAGE_XML)
string(REGEX MATCH "<version>[0-9]+\\.[0-9]+\\.[0-9]+</version>" DIRTY_VERSION_STRING ${PACKAGE_XML})
string(REGEX REPLACE "^<version>([0-9]+)\\.([0-9]+)\\.([0-9]+)</version>$" "\\1" DART_MAJOR_VERSION "${DIRTY_VERSION_STRING}")
string(REGEX REPLACE "^<version>([0-9]+)\\.([0-9]+)\\.([0-9]+)</version>$" "\\2" DART_MINOR_VERSION "${DIRTY_VERSION_STRING}")
string(REGEX REPLACE "^<version>([0-9]+)\\.([0-9]+)\\.([0-9]+)</version>$" "\\3" DART_PATCH_VERSION "${DIRTY_VERSION_STRING}")
set(DART_VERSION "${DART_MAJOR_VERSION}.${DART_MINOR_VERSION}.${DART_PATCH_VERSION}")
But perhaps this brings more complexity that it is worth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like me to add this to this PR or is this a comment to keep track of for future reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think package.xml or semver supports a third period (beyond patch release). How about 0.6.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the requested updates. Note that the version convention won't allow 0.6.4.100
. It has to be major-minor-patch. Hence, I've used 0.6.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wxmerkt, thank you very much for the contribution! I've added just a comment regarding the deprecation of the methods you modified.
Thank you very much @wxmerkt for the effort, I am going to merge it 😃 |