Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend plugin paths #34

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Extend plugin paths #34

merged 4 commits into from
Jul 6, 2020

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Jul 3, 2020

This PR aims to extend the plugin search directories, gazebo-fashioned.

TODO:

  • Check old functionality(local dir)
  • Check new functionality(plugin paths)
  • Add documentation

@Nicogene Nicogene added the enhancement New feature or request label Jul 3, 2020
@Nicogene Nicogene requested a review from triccyx July 3, 2020 08:33
@Nicogene Nicogene self-assigned this Jul 3, 2020
@Nicogene Nicogene marked this pull request as draft July 3, 2020 08:33
@traversaro
Copy link
Member

FYI the sharedlibpp version as modified in blockfactory also contains some of this logic, see robotology/blockfactory#32 .

@Nicogene
Copy link
Member Author

Nicogene commented Jul 3, 2020

I would start with a quick and dirty solution and see if works, and then the introduction of sharedlippwould be nice, but unfortunately we have to do yet another fork 😞

The best solution would be having a unique sharedlibpp and use it everywhere (https://github.com/icub-tech-iit/tickets/issues/379).

@traversaro
Copy link
Member

I would start with a quick and dirty solution and see if works, and then the introduction of sharedlippwould be nice, but unfortunately we have to do yet another fork 😞

Yes, that was just a link that I shared FYI, going forward with this change is definitely the way to go for now.

@triccyx triccyx marked this pull request as ready for review July 3, 2020 10:11
@Nicogene Nicogene force-pushed the feat/extendPluginPaths branch from e1e885d to c812c17 Compare July 3, 2020 13:23
Nicogene added 2 commits July 3, 2020 17:00
TO be tested also to check the win32 separators not handled
@triccyx triccyx merged commit 43bfec4 into devel Jul 6, 2020
@triccyx triccyx deleted the feat/extendPluginPaths branch July 6, 2020 12:38
@Nicogene Nicogene restored the feat/extendPluginPaths branch July 6, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants