Handle expired refresh tokens "gracefully" #67
build-and-publish.yml
on: pull_request
Annotations
12 warnings
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
build:
libs/Roblox/Roblox/Implementation/Clients/AuthenticationClient.cs#L145
Change AuthenticationClient.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
|
build:
libs/Roblox/Roblox/Implementation/HttpClientExtensions.cs#L45
The behavior of 'FormattableString.ToString()' could vary based on the current user's locale settings. Replace this call in 'HttpClient.SendApiRequestAsync<TResult>(HttpMethod, string, FormattableString, IReadOnlyDictionary<string, string>, CancellationToken)' with a call to 'FormattableString.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
build:
libs/Roblox/Roblox/Implementation/HttpClientExtensions.cs#L70
The behavior of 'FormattableString.ToString()' could vary based on the current user's locale settings. Replace this call in 'HttpClient.SendApiRequestAsync<TRequest, TResult>(HttpMethod, string, FormattableString, IReadOnlyDictionary<string, string>, TRequest, CancellationToken)' with a call to 'FormattableString.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
build:
libs/Roblox/Roblox/Models/Request/Thumbnails/ThumbnailRequest.cs#L17
The behavior of 'long.Parse(string)' could vary based on the current user's locale settings. Replace this call in 'ThumbnailRequest.TargetId.get' with a call to 'long.Parse(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
build:
libs/Roblox/Roblox/Models/Request/Thumbnails/AvatarRenderBodyColors.cs#L38
Member 'GetHexById' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
build:
libs/Roblox/Roblox/Implementation/Clients/CatalogClient.cs#L135
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'CatalogClient.SearchAsync(CatalogSearchRequest, string, CancellationToken)' with a call to 'string.ToLower(CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
|
build:
libs/Roblox/Roblox.Tests/AssetTypeTests.cs#L15
Remove the underscores from member name Roblox.Tests.AssetTypeTests.GetDisplayName_ValidAssetType_ReturnsDisplayName(Roblox.Api.AssetType) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
|
build:
libs/Roblox/Roblox.Tests/RobloxDomainTests.cs#L40
Remove the underscores from member name Roblox.Tests.RobloxDomainTests.Build_ValidArguments_ReturnsUrl(string, string, System.Collections.Generic.IReadOnlyDictionary<string, string>) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
|
build:
libs/Roblox/Roblox.Tests/RobloxDomainTests.cs#L53
Remove the underscores from member name Roblox.Tests.RobloxDomainTests.BuildWebsiteItemUrl_ValidArguments_ReturnsUrl(string, long, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
|
build:
libs/Roblox/Roblox/Implementation/Clients/AuthenticationClient.cs#L145
Change AuthenticationClient.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "nuget-packages".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
nuget-packages
Expired
|
58.4 KB |
|