Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding maven to repositories #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vtrifonov
Copy link

There are currently two problems with adding maven to the repositories.

  1. When adding it to the platforms/android/build.gradle we need to add it before the closing } but not after it, that's why I'm subtracting 1 from the index and size of the matched block:
search = (buildGradleContent.indexOf(repositories[0]) - 1) + (repositories[0].length - 1);
  1. In the latest version of platforms/android/app/build.gradle in the repositories section we don't need to add the maven repository as it is already added in the platforms/android/build.gradle file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant