add previous #216
Closed
add previous #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvjing2
force-pushed
the
add-latest-previous
branch
from
b6db3af to
264fe75
Compare
|
@robfig Hi, How do you think if add the previous in this MR? |
|
Thanks for this MR. I would also appreciate this feature. See: #224 |
lonre
reviewed
Aug 24, 2019
|
Hi @robfig. Seems like it was renamed by the creator. Care to review again? Would love to have this! |
|
@robfig Hi, Is there any problem in this MR? If yes, would you like to share it to us? |
|
I'm not sure.. This seems like a lot of code for little benefit. Schedule is an interface, so folks can customize it for their use case. You can have a PrevSchedule that implements this if you wish. I don't want to support this use case, though. Sorry! |
|
Thanks @lvjing2 for the example implementation. This is extremely useful when identifying a backlog of missed runs. |
This was referenced Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the get the latest previous activation time.